Change bevy_pbr::morph shader functions to use descriptor index#24085
Open
komadori wants to merge 4 commits intobevyengine:mainfrom
Open
Change bevy_pbr::morph shader functions to use descriptor index#24085komadori wants to merge 4 commits intobevyengine:mainfrom
komadori wants to merge 4 commits intobevyengine:mainfrom
Conversation
greeble-dev
suggested changes
May 3, 2026
Co-authored-by: Greeble <166992735+greeble-dev@users.noreply.github.com>
greeble-dev
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The shader functions
bevy_pbr::morphtake aninstance_indexas a parameter and use it solely to look up themorph_descriptor_indexin themesharray. This prevents these functions from being used in an environment without instance indices and the mesh array available.This is closely related to #24083 and porting bevy_mod_outline to 0.19-dev. I have put them in separate PRs because I consider #24083 a prerequisite to supporting morphed meshes without significant duplication both of code and work at runtime, and it is a very trivial change. I am in favour of this PR also, but if it is not merged for 0.19 then it is tractable to duplicate Bevy's morph shader functions inside bevy_mod_outline.
Solution
Testing